Comments on: Ruby Text Search http://davedupre.com/2007/08/02/ruby-text-search/ Some random thoughts - Go big or stay home! Wed, 10 Mar 2010 20:53:55 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Dave http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-388 Dave Tue, 24 Feb 2009 15:54:23 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-388 I added ARTICLE_WORDS to the github repository. Sorry about that. I added ARTICLE_WORDS to the github repository. Sorry about that.

]]> By: Dave http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-387 Dave Tue, 24 Feb 2009 15:37:47 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-387 That's what happens when there are not enough tests. You miss something. Sorry about that. I tried things in several of my other projects, and everything. However, all those projects had ARTICLE_WORDS define. I will fix ASAP. That’s what happens when there are not enough tests. You miss something. Sorry about that. I tried things in several of my other projects, and everything. However, all those projects had ARTICLE_WORDS define. I will fix ASAP.

]]> By: jerry http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-386 jerry Tue, 24 Feb 2009 15:27:00 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-386 Hi does the plugin include all methods that are needed? Iam getting errors about unknown methods. I think the missing methods were inside the extensions.rb file before . Below is the line that gives me errors: when /^(\w|(#{String::ARTICLE_WORDS.join('|')}))$/ Hi does the plugin include all methods that are needed? Iam getting errors about unknown methods. I think the missing methods were inside the extensions.rb file before .

Below is the line that gives me errors:

when /^(\w|(#{String::ARTICLE_WORDS.join(‘|’)}))$/

]]> By: Dave http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-371 Dave Wed, 18 Feb 2009 20:44:50 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-371 OK. I quickly wrapped up what I have as a plugin. You can get it on GitHub. See http://github.com/gobigdave/simple_model_search/tree/master. From the links there, you should be able to easily install search as a plugin. As I mentioned, there are no real tests in there. If I get a chance, I will add some. Don't forget to remove your old version of search.lib. OK. I quickly wrapped up what I have as a plugin. You can get it on GitHub. See http://github.com/gobigdave/simple_model_search/tree/master. From the links there, you should be able to easily install search as a plugin.

As I mentioned, there are no real tests in there. If I get a chance, I will add some.

Don’t forget to remove your old version of search.lib.

]]> By: Dave http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-370 Dave Wed, 18 Feb 2009 19:55:15 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-370 I haven't gotten around to turning this into a plugin yet because I don't think I have enough tests. Been working on 3 other projects so haven't had the cycles to give this what it deserves. Let me see what I can do tonight. I haven’t gotten around to turning this into a plugin yet because I don’t think I have enough tests. Been working on 3 other projects so haven’t had the cycles to give this what it deserves. Let me see what I can do tonight.

]]> By: Josh http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-369 Josh Wed, 18 Feb 2009 14:23:58 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-369 Dave, Great work here BUT it looks like you have added a lot since the last posting of your files. Did you ever turn this into a plugin and, if not, where can we get the latest and greated? Thanks, Josh Dave,

Great work here BUT it looks like you have added a lot since the last posting of your files.

Did you ever turn this into a plugin and, if not, where can we get the latest and greated?

Thanks,

Josh

]]> By: Dave http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-353 Dave Fri, 06 Feb 2009 02:00:35 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-353 Good catch! In my production apps, I require more than one character before I allow a search, so I never saw or tested this case. I can't say exactly why it happens, but I have some ideas. I'm guessing that something about make_chunks doesn't like a single character. I also know articles and some characters are removed (punctuation, etc.). If you remove everything, you end up with a where clause that is something like "table.col like '%%', and that will match everything. The question is whether it would a valid case to do a full text search for a single character. Normally, it's no, so I would probably lean towards handling conditions being blank the same as the search text being blank and return an empty collection instead of everything. Good catch! In my production apps, I require more than one character before I allow a search, so I never saw or tested this case. I can’t say exactly why it happens, but I have some ideas. I’m guessing that something about make_chunks doesn’t like a single character. I also know articles and some characters are removed (punctuation, etc.). If you remove everything, you end up with a where clause that is something like “table.col like ‘%%’, and that will match everything.

The question is whether it would a valid case to do a full text search for a single character. Normally, it’s no, so I would probably lean towards handling conditions being blank the same as the search text being blank and return an empty collection instead of everything.

]]> By: Eyal http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-352 Eyal Fri, 06 Feb 2009 01:50:58 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-352 Hi Dave, another question: I noticed that in both my app and your profit app, a search on only one character gives me back all the results in the table. As in Profit.search("$") == Profit.find(:all). Any idea why this is? Thanks, Eyal Hi Dave, another question:

I noticed that in both my app and your profit app, a search on only one character gives me back all the results in the table.

As in Profit.search(“$”) == Profit.find(:all). Any idea why this is?

Thanks,
Eyal

]]> By: Dave http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-350 Dave Thu, 05 Feb 2009 01:03:32 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-350 No problem. Glad I could help. No problem. Glad I could help.

]]> By: Eyal http://davedupre.com/2007/08/02/ruby-text-search/comment-page-2/#comment-349 Eyal Thu, 05 Feb 2009 00:25:26 +0000 http://davedupre.com/2007/08/02/ruby-text-search/#comment-349 Of course! Thanks so much. I should have seen that. self.charities_options is for the early stages of my development when I only have a few charities and I want to create a drop down select menu. Thanks again! Of course! Thanks so much. I should have seen that. self.charities_options is for the early stages of my development when I only have a few charities and I want to create a drop down select menu.

Thanks again!

]]>